[all-commits] [llvm/llvm-project] 867c34: [lldb] Fix that log enable's -f parameter causes L...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Mon Aug 17 01:43:52 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 867c347c32e27825a649af1ca5ccf22c350d2b8c
      https://github.com/llvm/llvm-project/commit/867c347c32e27825a649af1ca5ccf22c350d2b8c
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M lldb/source/Core/Debugger.cpp
    M lldb/test/API/commands/log/invalid-args/TestInvalidArgsLog.py

  Log Message:
  -----------
  [lldb] Fix that log enable's -f parameter causes LLDB to crash when it can't open the log file

We didn't do anything with the llvm::Error we get from `Open`, so when we end up in the
error case we just crash due to the llvm::Error sanity check. Also add the missing newline
behind the error message so it no longer messes with the next (lldb) prompt.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D85970




More information about the All-commits mailing list