[all-commits] [llvm/llvm-project] c1f9c1: [DFSan] Fix parameters to strtoull wrapper.

Matt Morehouse via All-commits all-commits at lists.llvm.org
Fri Aug 14 08:02:55 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c1f9c1c13cff0468964c3f4059b6857aaf818841
      https://github.com/llvm/llvm-project/commit/c1f9c1c13cff0468964c3f4059b6857aaf818841
  Author: Matt Morehouse <mascasa at google.com>
  Date:   2020-08-14 (Fri, 14 Aug 2020)

  Changed paths:
    M compiler-rt/lib/dfsan/dfsan_custom.cpp
    M compiler-rt/test/dfsan/custom.cpp

  Log Message:
  -----------
  [DFSan] Fix parameters to strtoull wrapper.

base and nptr_label were swapped, which meant we were passing nptr's
shadow as the base to the operation.  Usually, the shadow is 0, which
causes strtoull to guess the correct base from the string prefix (e.g.,
0x means base-16 and 0 means base-8), hiding this bug.  Adjust the test
case to expose the bug.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D85935




More information about the All-commits mailing list