[all-commits] [llvm/llvm-project] 399e45: [clangd] Fix find_program() result check when sear...

Aleksandr Platonov via All-commits all-commits at lists.llvm.org
Fri Aug 14 01:34:38 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 399e4593431cf146c52fc286670f88d6217db631
      https://github.com/llvm/llvm-project/commit/399e4593431cf146c52fc286670f88d6217db631
  Author: Aleksandr Platonov <platonov.aleksandr at huawei.com>
  Date:   2020-08-14 (Fri, 14 Aug 2020)

  Changed paths:
    M llvm/cmake/modules/FindGRPC.cmake

  Log Message:
  -----------
  [clangd] Fix find_program() result check when searching for gRPC

`find_program(<VAR> ...)` sets <VAR> to <VAR>-NOTFOUND if nothing was found.
So we need to compare <VAR> with "<VAR>-NOTFOUND" or just use `if([NOT] <VAR>)`, because `if(<VAR>)` is false if `<VAR>` ends in the suffix -NOTFOUND.

Reviewed By: kbobyrev

Differential Revision: https://reviews.llvm.org/D85958




More information about the All-commits mailing list