[all-commits] [llvm/llvm-project] e8ebeb: [InstCombine] Fix incorrect Modified status

David via All-commits all-commits at lists.llvm.org
Thu Aug 13 06:11:32 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e8ebebb0bde602199c4012efbcfe823f7ab9337f
      https://github.com/llvm/llvm-project/commit/e8ebebb0bde602199c4012efbcfe823f7ab9337f
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2020-08-13 (Thu, 13 Aug 2020)

  Changed paths:
    M llvm/include/llvm/Transforms/Utils/Local.h
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
    M llvm/lib/Transforms/Scalar/SCCP.cpp
    M llvm/lib/Transforms/Utils/Local.cpp
    A llvm/test/Transforms/InstCombine/unreachable-dbg-info-modified.ll

  Log Message:
  -----------
  [InstCombine] Fix incorrect Modified status

When removing instructions from unreachable blocks, and only debug info
intrinsics were removed, InstCombine could incorrectly return a false
Modified status.

This is fixed by making removeAllNonTerminatorAndEHPadInstructions()
also return how many debug info intrinsics that were removed, and take
that into account.

This was caught using the check introduced by D80916.

Reviewed By: majnemer

Differential Revision: https://reviews.llvm.org/D85839




More information about the All-commits mailing list