[all-commits] [llvm/llvm-project] 18b1e6: [AMDGPU] Fix crash when dag-combining bitcast

Ruiling, Song via All-commits all-commits at lists.llvm.org
Wed Aug 12 19:24:43 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 18b1e675232b44c905bce28211286f7df6434f27
      https://github.com/llvm/llvm-project/commit/18b1e675232b44c905bce28211286f7df6434f27
  Author: Ruiling Song <ruiling.song at amd.com>
  Date:   2020-08-13 (Thu, 13 Aug 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/test/CodeGen/AMDGPU/amdgcn.bitcast.ll

  Log Message:
  -----------
  [AMDGPU] Fix crash when dag-combining bitcast

>From the code after the 'break', they are processing 64bit scalar and
vector bitcast. So I think the break-condition should be (cond1 || cond2)
This means we only execute following code if (64bit and dest-is-vector).

Also remove a previous fix which is not needed with this new fix.
(introduced in: 1349a04ef5f594dda705ec80474dda4837f26dba)

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D85804




More information about the All-commits mailing list