[all-commits] [llvm/llvm-project] 5f7cdb: [X86][GlobalISel] Legalize G_ICMP results to s8.

topperc via All-commits all-commits at lists.llvm.org
Wed Aug 12 10:17:02 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5f7cdb2effa213e1bb4cbf765b8bcb5d6604d435
      https://github.com/llvm/llvm-project/commit/5f7cdb2effa213e1bb4cbf765b8bcb5d6604d435
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-08-12 (Wed, 12 Aug 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86LegalizerInfo.cpp
    M llvm/test/CodeGen/X86/GlobalISel/cmp.ll
    M llvm/test/CodeGen/X86/GlobalISel/legalize-cmp.mir
    M llvm/test/CodeGen/X86/GlobalISel/legalize-phi.mir
    M llvm/test/CodeGen/X86/GlobalISel/regbankselect-X86_64.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-cmp.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-phi.mir

  Log Message:
  -----------
  [X86][GlobalISel] Legalize G_ICMP results to s8.

We need to produce a setcc instruction which has an 8-bit result.
This gets rid of a bunch of cases that were using the s1->s8/s16/s32/s64
handling in selectZExt.

I'm not very familiar with GlobalISel yet so I'm not yet sure
the best way to do things. I'd especially like feedback on the
best way to handle the currently split 32-bit and 64-bit mode
handling.

Differential Revision: https://reviews.llvm.org/D85814




More information about the All-commits mailing list