[all-commits] [llvm/llvm-project] d110d4: [InstSimplify] Forbid undef folds in expandBinOp

Nikita Popov via All-commits all-commits at lists.llvm.org
Tue Aug 11 09:39:47 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d110d4aaff31198cd455b68617978019a8339773
      https://github.com/llvm/llvm-project/commit/d110d4aaff31198cd455b68617978019a8339773
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2020-08-11 (Tue, 11 Aug 2020)

  Changed paths:
    M llvm/include/llvm/Analysis/InstructionSimplify.h
    M llvm/lib/Analysis/InstructionSimplify.cpp

  Log Message:
  -----------
  [InstSimplify] Forbid undef folds in expandBinOp

This is the replacement for D84250 based on D84792. As we recursively
fold with the same value twice, we need to disable undef folds,
to prevent an undef from being folded to two different values.

Reverting rG00f3579aea6e3d4a4b7464c3db47294f71cef9e4 and using the
test case from https://reviews.llvm.org/D83360#2145793, it no longer
performs the incorrect fold.

Differential Revision: https://reviews.llvm.org/D85684




More information about the All-commits mailing list