[all-commits] [llvm/llvm-project] 026e0b: [LLD][ELF] - Update and fix gnu-ifunc* tests.

Georgii Rymar via All-commits all-commits at lists.llvm.org
Tue Aug 11 05:15:28 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 026e0bf984c617fa2ff4347e47deb069e23fde11
      https://github.com/llvm/llvm-project/commit/026e0bf984c617fa2ff4347e47deb069e23fde11
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-08-11 (Tue, 11 Aug 2020)

  Changed paths:
    M lld/test/ELF/Inputs/shared2-x86-64.s
    M lld/test/ELF/gnu-ifunc-plt-i386.s
    M lld/test/ELF/gnu-ifunc-plt.s

  Log Message:
  -----------
  [LLD][ELF] - Update and fix gnu-ifunc* tests.

It turns that gnu-ifunc-plt-i386.s and gnu-ifunc-plt.s tests are broken.

Initially they were implemented in D27581 and tested that `IRELATIVE` relocations
are placed after other relocations in `.rel.plt`.

Later, we started to place `IRELATIVE` relocations to `.rela.dyn` (D65651).

Also, at some point `.plt` was renamed to `.iplt` (D71520).

Now, `gnu-ifunc*` tests mentioned do not test what they intended to test initially:
they should test that `IRELATIVE` relocations are placed after other ones in
`.rela.dyn`. Also, comments needs to be updated accordingly after changes performed.

This patch updates them.

Differential revision: https://reviews.llvm.org/D85642




More information about the All-commits mailing list