[all-commits] [llvm/llvm-project] dc096a: [Diagnostics] Diagnose missing comma in string arr...

Dávid Bolvanský via All-commits all-commits at lists.llvm.org
Sat Aug 8 10:24:53 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dc096a66cb519532121fb0fbedb13265bd4b29ec
      https://github.com/llvm/llvm-project/commit/dc096a66cb519532121fb0fbedb13265bd4b29ec
  Author: Dávid Bolvanský <david.bolvansky at gmail.com>
  Date:   2020-08-08 (Sat, 08 Aug 2020)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaExpr.cpp
    A clang/test/Sema/string-concat.c

  Log Message:
  -----------
  [Diagnostics] Diagnose missing comma in string array initialization

Motivation (from PR37674):

const char *ss[] = {
  "foo", "bar",
  "baz", "qux"  // <-- Missing comma!
  "abc", "xyz"
  };

This kind of bug was recently also found in LLVM codebase (see PR47030).

Solves PR47038, PR37674

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D85545




More information about the All-commits mailing list