[all-commits] [llvm/llvm-project] b6b0ff: [DebugInfo] Clean up DIEUnit. NFC.

Igor Kudrin via All-commits all-commits at lists.llvm.org
Fri Aug 7 02:09:45 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b6b0ff18a3126500361223088aabafa8ea74d779
      https://github.com/llvm/llvm-project/commit/b6b0ff18a3126500361223088aabafa8ea74d779
  Author: Igor Kudrin <ikudrin at accesssoftek.com>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/DIE.h
    M llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h
    M llvm/lib/CodeGen/AsmPrinter/DIE.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
    M llvm/unittests/DebugInfo/DWARF/DwarfGenerator.h

  Log Message:
  -----------
  [DebugInfo] Clean up DIEUnit. NFC.

This removes members of the DIEUnit class which were used only in unit
tests. Note also that child classes shadowed some of these methods,
namely, getDwarfVersion() was overridden in DwartfUnit and getLength()
was overridden in DwarfCompileUnit.

Differential Revision: https://reviews.llvm.org/D85436


  Commit: 1eade73d8b0d8a08e7f3a62856a1f2004a046efb
      https://github.com/llvm/llvm-project/commit/1eade73d8b0d8a08e7f3a62856a1f2004a046efb
  Author: Igor Kudrin <ikudrin at accesssoftek.com>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfUnit.h

  Log Message:
  -----------
  [DebugInfo] Remove DwarfUnit::getDwarfVersion(). NFC.

This helper method was used only in one place, which can easily use the
direct call.

Differential revision: https://reviews.llvm.org/D85438


Compare: https://github.com/llvm/llvm-project/compare/ba41a0f7339c...1eade73d8b0d


More information about the All-commits mailing list