[all-commits] [llvm/llvm-project] e7af98: [lldb-vscode ]Add Syntax Highlighting to Disassemb...

walter erquinigo via All-commits all-commits at lists.llvm.org
Tue Aug 4 13:32:13 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e7af98680ad52ffc6d308ef63667ac6fb4bb16a7
      https://github.com/llvm/llvm-project/commit/e7af98680ad52ffc6d308ef63667ac6fb4bb16a7
  Author: Yifan Shen <aelitashen at fb.com>
  Date:   2020-08-04 (Tue, 04 Aug 2020)

  Changed paths:
    M lldb/tools/lldb-vscode/lldb-vscode.cpp
    M lldb/tools/lldb-vscode/package.json
    A lldb/tools/lldb-vscode/syntaxes/arm.disasm
    A lldb/tools/lldb-vscode/syntaxes/arm64.disasm
    A lldb/tools/lldb-vscode/syntaxes/disassembly.json
    A lldb/tools/lldb-vscode/syntaxes/x86.disasm

  Log Message:
  -----------
  [lldb-vscode ]Add Syntax Highlighting to Disassembly View

When lldb cannot find source file thus IDE renders a disassembly view, add syntax highlighting for constants, registers and final line comments for better debugging experience.
The original plain disassembly view looks like:
{F12401687}
An ideal view is like the screenshot attached.
{F12401515}

In this diff, the mimeType is a kind of media type for formatting the content in the response to a source request. Elements in the disassembly view, like constants, registers and final line comments are colored for highlighting.
A built-in support in the VSCode IDE for syntax highlighting will identify the which mimeType to apply and render the disassembly view as expected.

Reviewed By: wallace, clayborg

Differential Revision: https://reviews.llvm.org/D84555




More information about the All-commits mailing list