[all-commits] [llvm/llvm-project] 1f166e: [lld][linkerscript] Fix handling of DEFINED.

[abidh via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f166edeb47ea3584f4f6a267a9054af994af45c
      https://github.com/llvm/llvm-project/commit/1f166edeb47ea3584f4f6a267a9054af994af45c
  Author: Hafiz Abid Qadeer <abidh at codesourcery.com>
  Date:   2020-07-28 (Tue, 28 Jul 2020)

  Changed paths:
    M lld/ELF/ScriptParser.cpp
    M lld/test/ELF/linkerscript/Inputs/define.s
    M lld/test/ELF/linkerscript/define.test

  Log Message:
  -----------
  [lld][linkerscript] Fix handling of DEFINED.

Current implementation did not check that symbols is actually defined. Only checked for presence.  GNU ld documentation says,

"Return 1 if symbol is in the linker global symbol table and is defined before the statement using DEFINED in the script, otherwise return 0."

https://sourceware.org/binutils/docs/ld/Builtin-Functions.html#Builtin-Functions

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D83758