[all-commits] [llvm/llvm-project] 4853a8: [lld-macho] Support -filelist

[Jez Ng via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4853a86022feee1b16249cc7a0ea12c842fa5986
      https://github.com/llvm/llvm-project/commit/4853a86022feee1b16249cc7a0ea12c842fa5986
  Author: Jez Ng <jezng at fb.com>
  Date:   2020-07-28 (Tue, 28 Jul 2020)

  Changed paths:
    M lld/MachO/Driver.cpp
    A lld/test/MachO/filelist.s
    A lld/test/MachO/invalid/no-filelist.s

  Log Message:
  -----------
  [lld-macho] Support -filelist

XCode passes files in using this flag

Reviewed By: #lld-macho, compnerd

Differential Revision: https://reviews.llvm.org/D84486


  Commit: d32e32500f92602ccedcf967df2915da6f3803d2
      https://github.com/llvm/llvm-project/commit/d32e32500f92602ccedcf967df2915da6f3803d2
  Author: Jez Ng <jezng at fb.com>
  Date:   2020-07-28 (Tue, 28 Jul 2020)

  Changed paths:
    M lld/MachO/Writer.cpp
    M lld/test/MachO/section-headers.s
    M lld/test/MachO/segments.s

  Log Message:
  -----------
  [lld-macho] Fix segment filesize calculation

The previous approach of adding up the file sizes of the
component sections ignored the fact that the sections did not have to be
contiguous in the file. As such, it was underestimating the true size.

I discovered this issue because `codesign` checks whether `__LINKEDIT`
extends to the end of the file. Since we were underestimating segment
sizes, this check failed.

Reviewed By: #lld-macho, compnerd

Differential Revision: https://reviews.llvm.org/D84574


Compare: https://github.com/llvm/llvm-project/compare/f761acfb1a73...d32e32500f92