[all-commits] [llvm/llvm-project] f3a043: [MC] [COFF] Make sure that weak external symbols a...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Mon Jul 27 04:17:31 PDT 2020


  Branch: refs/heads/release/11.x
  Home:   https://github.com/llvm/llvm-project
  Commit: f3a043717d265105ab854c5f84ec03c2f67d9a63
      https://github.com/llvm/llvm-project/commit/f3a043717d265105ab854c5f84ec03c2f67d9a63
  Author: Martin Storsjö <martin at martin.st>
  Date:   2020-07-27 (Mon, 27 Jul 2020)

  Changed paths:
    M llvm/lib/MC/WinCOFFObjectWriter.cpp
    A llvm/test/MC/COFF/weak-comdat.s

  Log Message:
  -----------
  [MC] [COFF] Make sure that weak external symbols are undefined symbols

For comdats (e.g. caused by -ffunction-sections), Section is already
set here; make sure it's null, for the weak external symbol to be undefined.

This fixes PR46779.

Differential Revision: https://reviews.llvm.org/D84507

(cherry picked from commit 9e81d8bbf19d72fca3d87b7334c613d1aa2a5795)




More information about the All-commits mailing list