[all-commits] [llvm/llvm-project] cee60b: [lldb] Remove the user-defined copy-ctor in ConstS...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cee60bbf417dbec1cb3df6fc465ac06295a0cd9d
      https://github.com/llvm/llvm-project/commit/cee60bbf417dbec1cb3df6fc465ac06295a0cd9d
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-07-23 (Thu, 23 Jul 2020)

  Changed paths:
    M lldb/include/lldb/Utility/ConstString.h
    M lldb/source/Core/IOHandlerCursesGUI.cpp

  Log Message:
  -----------
  [lldb] Remove the user-defined copy-ctor in ConstString

ConstString is essentially trivially copyable yet it has a user defined
copy constructor that copies its one member pointer. Remove it so it
qualifies as trivial in the eyes of the compiler.

This also fixes two unused variable warnings now that the compiler knows
that the constructor has no side-effects.

Differential revision: https://reviews.llvm.org/D84440