[all-commits] [llvm/llvm-project] 8d6aa6: Remove the "bool" return from OptionValue::Clear a...

[jimingham via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8d6aa688eeffea4b9151d1a208ed619ca50c823a
      https://github.com/llvm/llvm-project/commit/8d6aa688eeffea4b9151d1a208ed619ca50c823a
  Author: Jim Ingham <jingham at apple.com>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M lldb/include/lldb/Interpreter/OptionValue.h
    M lldb/include/lldb/Interpreter/OptionValueArch.h
    M lldb/include/lldb/Interpreter/OptionValueArray.h
    M lldb/include/lldb/Interpreter/OptionValueBoolean.h
    M lldb/include/lldb/Interpreter/OptionValueChar.h
    M lldb/include/lldb/Interpreter/OptionValueDictionary.h
    M lldb/include/lldb/Interpreter/OptionValueEnumeration.h
    M lldb/include/lldb/Interpreter/OptionValueFileColonLine.h
    M lldb/include/lldb/Interpreter/OptionValueFileSpec.h
    M lldb/include/lldb/Interpreter/OptionValueFileSpecList.h
    M lldb/include/lldb/Interpreter/OptionValueFormat.h
    M lldb/include/lldb/Interpreter/OptionValueFormatEntity.h
    M lldb/include/lldb/Interpreter/OptionValueLanguage.h
    M lldb/include/lldb/Interpreter/OptionValuePathMappings.h
    M lldb/include/lldb/Interpreter/OptionValueProperties.h
    M lldb/include/lldb/Interpreter/OptionValueRegex.h
    M lldb/include/lldb/Interpreter/OptionValueSInt64.h
    M lldb/include/lldb/Interpreter/OptionValueString.h
    M lldb/include/lldb/Interpreter/OptionValueUInt64.h
    M lldb/include/lldb/Interpreter/OptionValueUUID.h
    M lldb/source/Interpreter/OptionValueFormatEntity.cpp
    M lldb/source/Interpreter/OptionValueProperties.cpp

  Log Message:
  -----------
  Remove the "bool" return from OptionValue::Clear and its subclasses.

Every override returns true and its return value is never checked.  I can't
see how clearing an OptionValue could fail, or what you would
do if it did.  The return serves no purpose.

Differential Revision: https://reviews.llvm.org/D84253