[all-commits] [llvm/llvm-project] 84704d: AMDGPU: Fix not accounting for constantexpr uses o...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Mon Jul 20 08:42:04 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 84704d989b31b7d4cfc0eacfe8a8a25cba541cd0
      https://github.com/llvm/llvm-project/commit/84704d989b31b7d4cfc0eacfe8a8a25cba541cd0
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp
    A llvm/test/CodeGen/AMDGPU/promote-alloca-to-lds-constantexpr-use.ll

  Log Message:
  -----------
  AMDGPU: Fix not accounting for constantexpr uses of LDS globals

This was failing to add the size of LDS globals that weren't directly
used by an instruction. They could be used by constant expressions
which are transitively used by the function. This requires a better
search, but just abort on this for now for correctness.


  Commit: 21ef01b7e36e13b6874c3f41888268e3e03bb248
      https://github.com/llvm/llvm-project/commit/21ef01b7e36e13b6874c3f41888268e3e03bb248
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp

  Log Message:
  -----------
  AMDGPU: Remove outdated fixme


Compare: https://github.com/llvm/llvm-project/compare/177e5acbe4b9...21ef01b7e36e


More information about the All-commits mailing list