[all-commits] [llvm/llvm-project] 256aea: [llvm-readelf/readobj] - Refine the error reportin...

Georgii Rymar via All-commits all-commits at lists.llvm.org
Mon Jul 20 01:38:30 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 256aea816da45bd3bc52317cbc89e704095a8991
      https://github.com/llvm/llvm-project/commit/256aea816da45bd3bc52317cbc89e704095a8991
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M llvm/test/tools/llvm-readobj/ELF/mips-abiflags.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readelf/readobj] - Refine the error reporting in printMipsABIFlags() methods.

It fixes/improves the following:
1) Some code was duplicated.
2) A "The .MIPS.abiflags section has a wrong size" error was not reported as a warning,
   but was printed to stdout for the LLVM style. Also, it was reported as an error for the GNU style.
   This patch changes the behavior to be consistent and to report warnings.
3) `unwrapOrError()` was used before, now a warning is reported instead.

Differential revision: https://reviews.llvm.org/D84033




More information about the All-commits mailing list