[all-commits] [llvm/llvm-project] 6bddd0: Revert "[llvm-exegesis] Add benchmark latency opti...

Clement Courbet via All-commits all-commits at lists.llvm.org
Fri Jul 17 07:55:49 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6bddd099ac1434547dcc73da2552e97e1d89e58e
      https://github.com/llvm/llvm-project/commit/6bddd099ac1434547dcc73da2552e97e1d89e58e
  Author: Clement Courbet <courbet at google.com>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M llvm/docs/CommandGuide/llvm-exegesis.rst
    R llvm/test/tools/llvm-exegesis/X86/lbr/Inputs/mov_add.att
    R llvm/test/tools/llvm-exegesis/X86/lbr/lit.local.cfg
    R llvm/test/tools/llvm-exegesis/X86/lbr/mov-add.s
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/PerfHelper.cpp
    M llvm/tools/llvm-exegesis/lib/PerfHelper.h
    M llvm/tools/llvm-exegesis/lib/X86/CMakeLists.txt
    M llvm/tools/llvm-exegesis/lib/X86/Target.cpp
    R llvm/tools/llvm-exegesis/lib/X86/X86Counter.cpp
    R llvm/tools/llvm-exegesis/lib/X86/X86Counter.h
    M llvm/tools/llvm-exegesis/llvm-exegesis.cpp

  Log Message:
  -----------
  Revert "[llvm-exegesis] Add benchmark latency option on X86 that uses LBR for more precise measurements."

>From @erichkeane:
```
This patch doesn't seem to build for me:
/iusers/ekeane1/workspaces/llvm-project/llvm/tools/llvm-exegesis/lib/X86/X86Counter.cpp: In function ‘llvm::Error llvm::exegesis::parseDataBuffer(const char*, size_t, const void*, const void*, llvm::SmallVector<long int, 4>*)’:
/iusers/ekeane1/workspaces/llvm-project/llvm/tools/llvm-exegesis/lib/X86/X86Counter.cpp:99:37: error: ‘struct perf_branch_entry’ has no member named ‘cycles’

CycleArray->push_back(Entry.cycles);
I'm on RHEL7, so I have kernel 3.10, so it doesn't have 'cycles'.

According ot this: https://elixir.bootlin.com/linux/v4.3/source/include/uapi/linux/perf_event.h#L963 kernel 4.3 is the first time that 'cycles' appeared in this structure.
```




More information about the All-commits mailing list