[all-commits] [llvm/llvm-project] 265966: [libc++] Remove shortcut Lit features for Apple ba...

[Louis Dionne via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2659663ee31890bae63054c6fce5d444d1975ee2
      https://github.com/llvm/llvm-project/commit/2659663ee31890bae63054c6fce5d444d1975ee2
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/default.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/move_assign.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/move_ctor.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_adopt_lock.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_defer_lock.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_duration.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_time_point.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_try_to_lock.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/lock.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.obs/mutex.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.obs/op_bool.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.obs/owns_lock.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.assign/copy.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.assign/move.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.assign/value.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.cons/copy.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.cons/in_place_type.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.cons/move.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.cons/value.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.modifiers/emplace.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.modifiers/reset.pass.cpp
    M libcxx/test/std/utilities/any/any.class/any.modifiers/swap.pass.cpp
    M libcxx/test/std/utilities/any/any.nonmembers/any.cast/any_cast_pointer.pass.cpp
    M libcxx/test/std/utilities/any/any.nonmembers/any.cast/any_cast_reference.pass.cpp
    M libcxx/test/std/utilities/any/any.nonmembers/any.cast/any_cast_request_invalid_value_category.fail.cpp
    M libcxx/test/std/utilities/any/any.nonmembers/any.cast/const_correctness.fail.cpp
    M libcxx/test/std/utilities/any/any.nonmembers/any.cast/not_copy_constructible.fail.cpp
    M libcxx/test/std/utilities/any/any.nonmembers/make_any.pass.cpp
    M libcxx/test/std/utilities/any/any.nonmembers/swap.pass.cpp
    M libcxx/test/std/utilities/optional/optional.bad_optional_access/default.pass.cpp
    M libcxx/test/std/utilities/optional/optional.bad_optional_access/derive.pass.cpp
    M libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/U.pass.cpp
    M libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/const_T.pass.cpp
    M libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/move.pass.cpp
    M libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/rvalue_T.pass.cpp
    M libcxx/test/std/utilities/optional/optional.object/optional.object.observe/value.pass.cpp
    M libcxx/test/std/utilities/optional/optional.object/optional.object.observe/value_const.pass.cpp
    M libcxx/test/std/utilities/optional/optional.object/optional.object.observe/value_const_rvalue.pass.cpp
    M libcxx/test/std/utilities/optional/optional.object/optional.object.observe/value_rvalue.pass.cpp
    M libcxx/test/std/utilities/optional/optional.specalg/make_optional.pass.cpp
    M libcxx/test/std/utilities/variant/variant.bad_variant_access/bad_variant_access.pass.cpp
    M libcxx/test/std/utilities/variant/variant.get/get_index.pass.cpp
    M libcxx/test/std/utilities/variant/variant.get/get_type.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.assign/move.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.ctor/default.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.ctor/in_place_index_args.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.ctor/in_place_index_init_list_args.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.ctor/in_place_type_args.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.ctor/in_place_type_init_list_args.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.ctor/move.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.mod/emplace_index_args.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.mod/emplace_index_init_list_args.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.mod/emplace_type_args.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.mod/emplace_type_init_list_args.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp
    M libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp
    M libcxx/utils/libcxx/test/config.py

  Log Message:
  -----------
  [libc++] Remove shortcut Lit features for Apple backdeployment

Some time ago, I introduced shortcut features like dylib-has-no-shared_mutex
to encode whether the deployment target supported shared_mutex (say). This
made the test suite annotations cleaner.

However, the problem with building Lit features on top of other Lit
features is that it's easier for them to become stale, especially when
they are generated programmatically. Furthermore, it makes the bar for
defining configurations from scratch higher, since more features have
to be defined. Instead, I think it's better to put the XFAILs in the
tests directly, which allows cleaning them up with a simple grep.