[all-commits] [llvm/llvm-project] af19b1: [NFCI] CFGSimplifyPass: change (the only) construc...

[Roman Lebedev via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: af19b1ceefce48534c138e223ba7cb1bfc9a02f8
      https://github.com/llvm/llvm-project/commit/af19b1ceefce48534c138e223ba7cb1bfc9a02f8
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/SimplifyCFGPass.cpp

  Log Message:
  -----------
  [NFCI] CFGSimplifyPass: change (the only) constructor to take SimplifyCFGOptions

Taking that long list of parameters is already simply unmaintainable.


  Commit: b2018198c32a0535bb1f5bb5b40fbcf50d8d47b7
      https://github.com/llvm/llvm-project/commit/b2018198c32a0535bb1f5bb5b40fbcf50d8d47b7
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M llvm/include/llvm/Transforms/Scalar.h
    M llvm/include/llvm/Transforms/Scalar/SimplifyCFG.h
    A llvm/include/llvm/Transforms/Scalar/SimplifyCFGOptions.h
    M llvm/include/llvm/Transforms/Utils/Local.h
    M llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
    M llvm/lib/Target/ARM/ARMTargetMachine.cpp
    M llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp
    M llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
    M llvm/lib/Transforms/Scalar/Scalar.cpp
    M llvm/lib/Transforms/Scalar/SimplifyCFGPass.cpp

  Log Message:
  -----------
  [NFCI] createCFGSimplificationPass(): migrate to also take SimplifyCFGOptions

Taking so many parameters is simply unmaintainable.

We don't want to include the entire llvm/Transforms/Utils/Local.h into
llvm/Transforms/Scalar.h so i've split SimplifyCFGOptions into
it's own header.


Compare: https://github.com/llvm/llvm-project/compare/3c2a56a85722...b2018198c32a