[all-commits] [llvm/llvm-project] 706ccc: [lldb] Make `process connect` blocking in synchron...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Tue Jul 14 08:45:54 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 706cccb889c8d14791c029a7bb69d8eddb6b1728
      https://github.com/llvm/llvm-project/commit/706cccb889c8d14791c029a7bb69d8eddb6b1728
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-07-14 (Tue, 14 Jul 2020)

  Changed paths:
    M lldb/include/lldb/Target/Platform.h
    M lldb/source/Commands/CommandObjectProcess.cpp
    M lldb/source/Target/Platform.cpp
    A lldb/test/API/functionalities/gdb_remote_client/TestProcessConnect.py

  Log Message:
  -----------
  [lldb] Make `process connect` blocking in synchronous mode.

In synchronous mode, the process connect command and its aliases should
wait for the stop event before claiming the command is complete.
Currently, the stop event is always handled asynchronously by the
debugger.

The implementation takes the same approach as Process::ResumeSynchronous
which hijacks the event and handles it on the current thread. Similarly,
after this patch, the stop event is part of the command return object,
which is the property used by the test case.

Differential revision: https://reviews.llvm.org/D83728




More information about the All-commits mailing list