[all-commits] [llvm/llvm-project] 15fa28: [flang] Support for image selectors

Pete Steinfeld via All-commits all-commits at lists.llvm.org
Wed Jul 8 07:32:31 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 15fa287b64d0ef845201339994cdf6eb3e4d51e1
      https://github.com/llvm/llvm-project/commit/15fa287b64d0ef845201339994cdf6eb3e4d51e1
  Author: Pete Steinfeld <psteinfeld at nvidia.com>
  Date:   2020-07-08 (Wed, 08 Jul 2020)

  Changed paths:
    M flang/include/flang/Parser/tools.h
    M flang/lib/Parser/tools.cpp
    M flang/lib/Semantics/check-coarray.cpp
    M flang/lib/Semantics/check-coarray.h
    M flang/lib/Semantics/expression.cpp
    A flang/test/Semantics/resolve94.f90

  Log Message:
  -----------
  [flang] Support for image selectors

Summary:
This change implements support for image selectors and image selector
specifications as described in section 9.6.

In check-coarray[.h,cpp] I changed the `Leave()` function for
`parser::ImageSelectorSpec` to take a `parser::ImageSelector`, which
contains a list of image selector specifications.  This allows us to
detect when the same specification is used more than once.  I also added
code to analyze the expressions for the image selector specifications to
expression.cpp and a test for all of the conditions to check at
compile-time.

Note that we do not check at compile-time to see if the value of the
cosubscripts are within the specified cobounds.  We also do not check anything
related to selecting a valid team.  We also do not check that the denotation of
the `stat-variable` is not dependent on the evaluation of an entity in the
same statement.

Reviewers: klausler, tskeith, DavidTruby

Subscribers: llvm-commits

Tags: #llvm, #flang

Differential Revision: https://reviews.llvm.org/D83336




More information about the All-commits mailing list