[all-commits] [llvm/llvm-project] c5263a: [clangd] Fix race in FileIndex that sometimes temp...

Sam McCall via All-commits all-commits at lists.llvm.org
Wed Jul 1 07:47:42 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c5263a4e84cc7fb7135a7e9e0cf000af264b72c5
      https://github.com/llvm/llvm-project/commit/c5263a4e84cc7fb7135a7e9e0cf000af264b72c5
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2020-07-01 (Wed, 01 Jul 2020)

  Changed paths:
    M clang-tools-extra/clangd/index/FileIndex.cpp
    M clang-tools-extra/clangd/index/FileIndex.h
    M clang-tools-extra/clangd/index/Symbol.h
    M clang-tools-extra/clangd/unittests/FileIndexTests.cpp

  Log Message:
  -----------
  [clangd] Fix race in FileIndex that sometimes temporarily lost updates.

Summary:
FileIndex was built out of threadsafe components, so update() didn't have data
races, but wasn't actually correct.

Reviewers: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D82891




More information about the All-commits mailing list