[all-commits] [llvm/llvm-project] 56bb1d: [lldb/api] Improve error reporting in SBBreakpoint...

Med Ismail Bennani via All-commits all-commits at lists.llvm.org
Wed Jul 1 03:37:22 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 56bb1d1755ae38b4e7a67f775978b18a601f215f
      https://github.com/llvm/llvm-project/commit/56bb1d1755ae38b4e7a67f775978b18a601f215f
  Author: Med Ismail Bennani <medismail.bennani at gmail.com>
  Date:   2020-07-01 (Wed, 01 Jul 2020)

  Changed paths:
    M lldb/bindings/interface/SBBreakpoint.i
    M lldb/include/lldb/API/SBBreakpoint.h
    M lldb/source/API/SBBreakpoint.cpp
    M lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py

  Log Message:
  -----------
  [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

This patch improves the error reporting for SBBreakpoint::AddName by
adding a new method `SBBreakpoint::AddNameWithErrorHandling` that returns
a SBError instead of a boolean.

This way, if the breakpoint naming failed in the backend, the client
(i.e. Xcode), will be able to report the reason of that failure to the
user.

rdar://64765461

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>




More information about the All-commits mailing list