[all-commits] [llvm/llvm-project] 5f56da: [llvm-install-name-tool] Tighten some path checks

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Tue Jun 30 17:25:15 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5f56da3763ac6d5cc38b474fb05a2c89542d207e
      https://github.com/llvm/llvm-project/commit/5f56da3763ac6d5cc38b474fb05a2c89542d207e
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-06-30 (Tue, 30 Jun 2020)

  Changed paths:
    M llvm/test/tools/llvm-objcopy/MachO/install-name-tool-change.test
    M llvm/test/tools/llvm-objcopy/MachO/install-name-tool-id.test

  Log Message:
  -----------
  [llvm-install-name-tool] Tighten some path checks

Just having --implicit-check-not=/usr breaks when the LLVM checkout path
contains '/usr', since llvm-objdump prints out the path to the input
file in the first line. Tighten the checks by adding the 'name' prefix
that's used when printing load command payloads. An alternative would be
to redirect the input file into llvm-objdump, in which case it prints
out 'a.out' as the file name, but I'm not sure how reliable that
behavior is.




More information about the All-commits mailing list