[all-commits] [llvm/llvm-project] 25055a: [mlir] add unsigned comparison builders to Affine ...

[Adam Straw via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 25055a4fb90292e49f44a0a708390a730cd1116e
      https://github.com/llvm/llvm-project/commit/25055a4fb90292e49f44a0a708390a730cd1116e
  Author: Adam D Straw <adam.d.straw at intel.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/Affine/EDSC/Builders.h
    M mlir/include/mlir/EDSC/Builders.h
    M mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp
    M mlir/lib/Dialect/Affine/EDSC/Builders.cpp
    M mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Loops.cpp
    M mlir/test/EDSC/builder-api-test.cpp

  Log Message:
  -----------
  [mlir] add unsigned comparison builders to Affine EDSC

Current Affine comparison builders, which use operator overload, default to signed comparison.  This creates the possibility of misuse of these builders and potential correctness issues when dealing with unsigned integers.  This change makes the distinction between signed and unsigned comparison builders and forces the caller to make a choice between the two.

Differential Revision: https://reviews.llvm.org/D82323