[all-commits] [llvm/llvm-project] 0c66af: [libc++] Allow specifying custom Lit config files

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Jun 18 07:07:14 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c66af970c806d65d9335c7272610c82c2388e31
      https://github.com/llvm/llvm-project/commit/0c66af970c806d65d9335c7272610c82c2388e31
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-06-18 (Thu, 18 Jun 2020)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxx/docs/TestingLibcxx.rst
    M libcxx/test/CMakeLists.txt
    R libcxx/test/lit.cfg
    A libcxx/test/lit.cfg.py
    M libcxx/test/lit.site.cfg.in

  Log Message:
  -----------
  [libc++] Allow specifying custom Lit config files

Before this patch, the libc++ test suite first loads lit.site.cfg
(generated by CMake), and then lit.cfg. It's also possible to load
lit.cfg before lit.site.cfg and to point to a custom lit.site.cfg
file using '--param=libcxx_site_config'. However, in that case, lit.cfg
still relies on the site configuration filling up the 'config' object
like the default lit.site.cfg file does, which isn't flexible enough.

This commit simplifies the setup by having just a single Lit site config
file per CMake configuration, and always loading exactly that config file.
However, the config file to use can be selected when setting up CMake via
the LIBCXX_TEST_CONFIG setting. Furthermore, the site configs are entirely
standalone, which means that a new site config can be added that doesn't
need to conform what's expected by config.py.

Differential Revision: https://reviews.llvm.org/D81846




More information about the All-commits mailing list