[all-commits] [llvm/llvm-project] 5c6219: [llvm] [CommandLine] Do not suggest really hidden ...

Michał Górny via All-commits all-commits at lists.llvm.org
Wed Jun 17 10:01:30 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5c621900a6614d6e27843c14157b4c2630c124c5
      https://github.com/llvm/llvm-project/commit/5c621900a6614d6e27843c14157b4c2630c124c5
  Author: Michał Górny <mgorny at gentoo.org>
  Date:   2020-06-17 (Wed, 17 Jun 2020)

  Changed paths:
    M llvm/lib/Support/CommandLine.cpp
    M llvm/unittests/Support/CommandLineTest.cpp

  Log Message:
  -----------
  [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup

Skip 'really hidden' options when performing lookup of the nearest
option when invalid option was passed.  Since these options aren't even
documented in --help-hidden, it seems inconsistent to suggest them
to users.

This fixes clang-tools-extra test failures due to unexpected suggestions
when linking the tools to LLVM dylib (that provides more options than
the subset of LLVM libraries linked directly).

Differential Revision: https://reviews.llvm.org/D82001


  Commit: 352558e69b3691cfdc8e1adc2a1fbb737bc67cbb
      https://github.com/llvm/llvm-project/commit/352558e69b3691cfdc8e1adc2a1fbb737bc67cbb
  Author: Michał Górny <mgorny at gentoo.org>
  Date:   2020-06-17 (Wed, 17 Jun 2020)

  Changed paths:
    M llvm/tools/llvm-cfi-verify/lib/CMakeLists.txt

  Log Message:
  -----------
  [llvm] Avoid linking llvm-cfi-verify to duplicate libs

Fix the CMake rules for LLVMCFIVerify library not to pull duplicate
LLVM .a libraries when linking to the dylib.  This prevents problems
due to duplicate symbols and apparently fixes mingw32.

This is an alternative approach to D44650 that just forces .a libraries
instead.  However, there doesn't seem to be any reason to do that.

Differential Revision: https://reviews.llvm.org/D81921


  Commit: 1ad5e3cd6b8147d6919a2dbee9b905f86ba50c97
      https://github.com/llvm/llvm-project/commit/1ad5e3cd6b8147d6919a2dbee9b905f86ba50c97
  Author: Michał Górny <mgorny at gentoo.org>
  Date:   2020-06-17 (Wed, 17 Jun 2020)

  Changed paths:
    M llvm/tools/llvm-exegesis/CMakeLists.txt

  Log Message:
  -----------
  [llvm] Disable linking llvm-exegesis to dylib

Force linking llvm-exegesis to static LLVM libraries instead of dylib
to prevent duplicate symbols due to linking both.  Ideally, we'd want
to link to the dylib only here but the target sub-libraries use hidden
symbols from LLVM target libraries and therefore linking the dylib
fails.

Differential Revision: https://reviews.llvm.org/D81922


  Commit: d4f298c8206b435ce627b022efa0d5da620019cd
      https://github.com/llvm/llvm-project/commit/d4f298c8206b435ce627b022efa0d5da620019cd
  Author: Michał Górny <mgorny at gentoo.org>
  Date:   2020-06-17 (Wed, 17 Jun 2020)

  Changed paths:
    M clang-tools-extra/clang-apply-replacements/CMakeLists.txt
    M clang-tools-extra/clang-change-namespace/CMakeLists.txt
    M clang-tools-extra/clang-doc/CMakeLists.txt
    M clang-tools-extra/clang-include-fixer/CMakeLists.txt
    M clang-tools-extra/clang-include-fixer/find-all-symbols/CMakeLists.txt
    M clang-tools-extra/clang-move/CMakeLists.txt
    M clang-tools-extra/clang-query/CMakeLists.txt
    M clang-tools-extra/clang-reorder-fields/CMakeLists.txt
    M clang-tools-extra/clang-tidy/CMakeLists.txt
    M clang-tools-extra/clang-tidy/abseil/CMakeLists.txt
    M clang-tools-extra/clang-tidy/android/CMakeLists.txt
    M clang-tools-extra/clang-tidy/boost/CMakeLists.txt
    M clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
    M clang-tools-extra/clang-tidy/cert/CMakeLists.txt
    M clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt
    M clang-tools-extra/clang-tidy/darwin/CMakeLists.txt
    M clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt
    M clang-tools-extra/clang-tidy/google/CMakeLists.txt
    M clang-tools-extra/clang-tidy/hicpp/CMakeLists.txt
    M clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt
    M clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
    M clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt
    M clang-tools-extra/clang-tidy/misc/CMakeLists.txt
    M clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
    M clang-tools-extra/clang-tidy/mpi/CMakeLists.txt
    M clang-tools-extra/clang-tidy/objc/CMakeLists.txt
    M clang-tools-extra/clang-tidy/openmp/CMakeLists.txt
    M clang-tools-extra/clang-tidy/performance/CMakeLists.txt
    M clang-tools-extra/clang-tidy/plugin/CMakeLists.txt
    M clang-tools-extra/clang-tidy/portability/CMakeLists.txt
    M clang-tools-extra/clang-tidy/readability/CMakeLists.txt
    M clang-tools-extra/clang-tidy/tool/CMakeLists.txt
    M clang-tools-extra/clang-tidy/utils/CMakeLists.txt
    M clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
    M clang-tools-extra/clangd/CMakeLists.txt
    M clang-tools-extra/clangd/unittests/CMakeLists.txt

  Log Message:
  -----------
  [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

Fix various tool libraries not to link to clang's .a libraries and dylib
simultaneously.  This may cause breakage, in particular through
duplicate command-line option declarations.

Differential Revision: https://reviews.llvm.org/D81967


Compare: https://github.com/llvm/llvm-project/compare/2956cc50f340...d4f298c8206b


More information about the All-commits mailing list