[all-commits] [llvm/llvm-project] 30d05b: [clangd][Hover] Handle uninstantiated default args

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Wed Jun 10 02:54:41 PDT 2020


  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 30d05b898c6e84160507a66aabba6aceb129a9c7
      https://github.com/llvm/llvm-project/commit/30d05b898c6e84160507a66aabba6aceb129a9c7
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-06-10 (Wed, 10 Jun 2020)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd][Hover] Handle uninstantiated default args

Summary:
Default args might exist but be unparsed or uninstantiated.
getDefaultArg asserts on those. This patch makes sure we don't crash in such
scenarios.

Reviewers: sammccall, ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D73723

(cherry-picked from commit 9c903d0373ff940f9143efab8d948edf776de9f1)

Fixes https://github.com/clangd/clangd/issues/424




More information about the All-commits mailing list