[all-commits] [llvm/llvm-project] 665dbe: Revert "[clangd] Parse std::make_unique, and emit ...

Sam McCall via All-commits all-commits at lists.llvm.org
Tue Jun 9 06:42:47 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 665dbe91f2ed97796691f3608db7e28519f43978
      https://github.com/llvm/llvm-project/commit/665dbe91f2ed97796691f3608db7e28519f43978
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M clang-tools-extra/clangd/Diagnostics.cpp
    M clang-tools-extra/clangd/Diagnostics.h
    M clang-tools-extra/clangd/Preamble.cpp
    M clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
    M clang/include/clang/Frontend/PrecompiledPreamble.h
    M clang/lib/Frontend/PrecompiledPreamble.cpp

  Log Message:
  -----------
  Revert "[clangd] Parse std::make_unique, and emit template diagnostics at expansion."

This reverts commit 658af9435071d5da017c1d65298bdea19ec095e1.
Breaks tests on windows: http://45.33.8.238/win/17229/step_9.txt

I think this is uncovering a latent bug when a late-parsed preamble is
used with an eagerly-parsed file.




More information about the All-commits mailing list