[all-commits] [llvm/llvm-project] 8133e2: Add ASan metadata globals to @llvm.compiler.used u...

aeubanks via All-commits all-commits at lists.llvm.org
Fri Jun 5 09:06:40 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8133e289b6f697cb5d102d7f78223b64098808b5
      https://github.com/llvm/llvm-project/commit/8133e289b6f697cb5d102d7f78223b64098808b5
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
    M llvm/test/Instrumentation/AddressSanitizer/global_metadata_windows.ll

  Log Message:
  -----------
  Add ASan metadata globals to @llvm.compiler.used under COFF

Summary:
This matches ELF.

This makes the number of ASan failures under the new pass manager on
Windows go from 18 to 1.

Under the old pass manager, the ASan module pass was one of the very
last things run, so these globals didn't get removed due to GlobalOpt.
But with the NPM the ASan module pass that adds these globals are run
much earlier in the pipeline and GlobalOpt ends up removing them.

Reviewers: vitalybuka, hans

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81175




More information about the All-commits mailing list