[all-commits] [llvm/llvm-project] dd5443: [InstNamer] use 'i' for Instructions, not 'tmp'

[RotateRight via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dd54432a0f5a6f042fa4d2db3094c6f02e5ad275
      https://github.com/llvm/llvm-project/commit/dd54432a0f5a6f042fa4d2db3094c6f02e5ad275
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-06-01 (Mon, 01 Jun 2020)

  Changed paths:
    M llvm/lib/Transforms/Utils/InstructionNamer.cpp
    M llvm/test/Transforms/InstNamer/basic.ll

  Log Message:
  -----------
  [InstNamer] use 'i' for Instructions, not 'tmp'

As discussed in https://bugs.llvm.org/show_bug.cgi?id=45951 and
D80584, the name 'tmp' is almost always a bad choice, but we have
a legacy of regression tests with that name because it was baked
into utils/update_test_checks.py.

This change makes -instnamer more consistent (already using "arg"
and "bb", the common LLVM shorthand). And it avoids the conflict
in telling users of the FileCheck script to run "-instnamer" to
create a better regression test and having that cause a warn/fail
in update_test_checks.py.