[all-commits] [llvm/llvm-project] 354922: Remove WrapperMatcherInterface

Dmitri Gribenko via All-commits all-commits at lists.llvm.org
Thu May 28 09:01:32 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 35492270ed705ea9ac98ba04c6fda1adafef613a
      https://github.com/llvm/llvm-project/commit/35492270ed705ea9ac98ba04c6fda1adafef613a
  Author: Dmitri Gribenko <gribozavr at gmail.com>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M clang/include/clang/ASTMatchers/ASTMatchersInternal.h

  Log Message:
  -----------
  Remove WrapperMatcherInterface

Summary:
WrapperMatcherInterface is an abstraction over a member variable -- in
other words, not much of an abstraction at all. I think it makes code
harder to read more than in helps with deduplication. Not to even
mention the questionable usage of the ~Interface suffix for a type with
state.

Reviewers: ymandel

Reviewed By: ymandel

Subscribers: arichardson, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D80704




More information about the All-commits mailing list