[all-commits] [llvm/llvm-project] eeedbd: [clangd] Make use of SourceOrder to find first ini...

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Mon May 25 22:32:34 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: eeedbd033612e105755156023bdeec2fba4eca21
      https://github.com/llvm/llvm-project/commit/eeedbd033612e105755156023bdeec2fba4eca21
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
    M clang-tools-extra/clangd/unittests/TweakTests.cpp

  Log Message:
  -----------
  [clangd] Make use of SourceOrder to find first initializer in DefineOutline

Summary:
Constructors can have implicit initializers, this was crashing define
outline. Make sure we find the first "written" ctor initializer to figure out
`:` location.

Fixes https://github.com/clangd/clangd/issues/400

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D80521




More information about the All-commits mailing list