[all-commits] [llvm/llvm-project] 79e5ec: On Windows, handle interrupt signals without crash...

James Henderson via All-commits all-commits at lists.llvm.org
Thu May 21 05:29:46 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 79e5ecfa7a6c19ff08d39664bd30f72ab6e4f940
      https://github.com/llvm/llvm-project/commit/79e5ecfa7a6c19ff08d39664bd30f72ab6e4f940
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-05-21 (Thu, 21 May 2020)

  Changed paths:
    M llvm/lib/Support/Windows/Signals.inc
    A llvm/test/Support/interrupts.test

  Log Message:
  -----------
  On Windows, handle interrupt signals without crash message

For LLVM on *nix systems, the signal handlers are not run on signals
such as SIGINT due to CTRL-C. See sys::CleanupOnSignal. This makes
sense, as such signals are not really crashes. Prior to this change,
this wasn't the case on Windows, however. This patch changes the Windows
behaviour to be consistent with Linux, and adds testing that verifies
this.

The test uses llvm-symbolizer, but any tool with an interactive mode
would do the job.

Fixes https://bugs.llvm.org/show_bug.cgi?id=45754.

Reviewed by: MaskRay, rnk, aganea

Differential Revision: https://reviews.llvm.org/D79847




More information about the All-commits mailing list