[all-commits] [llvm/llvm-project] 9f19cc: [libcxx][test] Portability fix for some locale-dep...

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed May 20 11:36:04 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9f19cc8cac893a887e1952ce764bb6b09a6785df
      https://github.com/llvm/llvm-project/commit/9f19cc8cac893a887e1952ce764bb6b09a6785df
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M libcxx/test/std/diagnostics/syserr/syserr.syserr/syserr.syserr.members/ctor_error_code.pass.cpp
    M libcxx/test/std/diagnostics/syserr/syserr.syserr/syserr.syserr.members/ctor_error_code_const_char_pointer.pass.cpp
    M libcxx/test/std/diagnostics/syserr/syserr.syserr/syserr.syserr.members/ctor_error_code_string.pass.cpp
    M libcxx/test/std/diagnostics/syserr/syserr.syserr/syserr.syserr.members/ctor_int_error_category.pass.cpp
    M libcxx/test/std/diagnostics/syserr/syserr.syserr/syserr.syserr.members/ctor_int_error_category_const_char_pointer.pass.cpp
    M libcxx/test/std/diagnostics/syserr/syserr.syserr/syserr.syserr.members/ctor_int_error_category_string.pass.cpp

  Log Message:
  -----------
  [libcxx][test] Portability fix for some locale-dependent tests.

Tests for `std::system_error` constructor marked as slightly non-portable.
One (but not the only one) reason for such non-portability is that these
tests assume the default locale to be set to "C" (or "POSIX").

However, the default locale for the process depends on OS and
environment. This patch adds explicit setting of the correct
locale expected by the tests.

Thanks to Andrey Maksimov for the patch.

Differential Revision: https://reviews.llvm.org/D72456




More information about the All-commits mailing list