[all-commits] [llvm/llvm-project] a675c1: [libcxx testing] Remove ALLOW_RETRIES from lock_gu...

David Zarzycki via All-commits all-commits at lists.llvm.org
Mon May 18 04:45:14 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a675c1dee483129611794f37e0867f565181827b
      https://github.com/llvm/llvm-project/commit/a675c1dee483129611794f37e0867f565181827b
  Author: David Zarzycki <dave at znu.io>
  Date:   2020-05-18 (Mon, 18 May 2020)

  Changed paths:
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.guard/adopt_lock.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.guard/mutex.pass.cpp

  Log Message:
  -----------
  [libcxx testing] Remove ALLOW_RETRIES from lock_guard tests

These two tests were clumsily using time measurements to determine
whether std::lock_guard was working correctly. In practice, this
approach merely verified that the underlying lock properly waits.

Now these two tests verify that lock is acquired, not dropped
prematurely, and finally, actually dropped at the end of the scope.




More information about the All-commits mailing list