[all-commits] [llvm/llvm-project] f88c7f: [MLIR][cmake][NFC] Update linkage checker for mlir...

[stephenneuendorffer via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f88c7fe46b37960599e15d373e6ebb0cb2efdc01
      https://github.com/llvm/llvm-project/commit/f88c7fe46b37960599e15d373e6ebb0cb2efdc01
  Author: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
  Date:   2020-05-17 (Sun, 17 May 2020)

  Changed paths:
    M mlir/cmake/modules/AddMLIR.cmake
    M mlir/tools/mlir-opt/CMakeLists.txt

  Log Message:
  -----------
  [MLIR][cmake][NFC] Update linkage checker for mlir-opt

New CMakeLists.txt for MLIRStandardOpsTransforms was incorrect, but wasn't
caught by the check.

Differential Revision: https://reviews.llvm.org/D80075


  Commit: 37ce8d6ade24b2fb9f332b5ff94c25b40f1fc701
      https://github.com/llvm/llvm-project/commit/37ce8d6ade24b2fb9f332b5ff94c25b40f1fc701
  Author: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
  Date:   2020-05-17 (Sun, 17 May 2020)

  Changed paths:
    M mlir/lib/Conversion/LinalgToStandard/CMakeLists.txt
    M mlir/lib/Dialect/StandardOps/Transforms/CMakeLists.txt
    M mlir/lib/ExecutionEngine/CMakeLists.txt
    M mlir/lib/IR/CMakeLists.txt
    M mlir/lib/Support/CMakeLists.txt

  Log Message:
  -----------
  [MLIR] Fix linkage for libMLIR.so

Generally:
1) don't use target_link_libraries() and add_mlir_library() on the same target, use LINK_LIBS PUBLIC instead.
2) don't use LINK_LIBS to specify LLVM libraries.  Use LINK_COMPONENTS instead
3) no need to link against LLVMSupport.  We pull it in by default.

Differential Revision: https://reviews.llvm.org/D80076


Compare: https://github.com/llvm/llvm-project/compare/52e98f620caf...37ce8d6ade24