[all-commits] [llvm/llvm-project] d5e9b7: [gn build] Put HAVE_LIBZ and HAVE_ZLIB_H behind ll...

Nico Weber via All-commits all-commits at lists.llvm.org
Fri May 15 13:19:18 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d5e9b76253d978dcf321e4f3c7c629d0f4dcd507
      https://github.com/llvm/llvm-project/commit/d5e9b76253d978dcf321e4f3c7c629d0f4dcd507
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn

  Log Message:
  -----------
  [gn build] Put HAVE_LIBZ and HAVE_ZLIB_H behind llvm_enable_zlib too.

In the CMake build, the HAVE_ vars are set based on system inspection,
and LLVM_ENABLE_ZLIB is set to false if neither's found. The GN build
doesn't do autodetection like this.

With this change, people can set llvm_enable_zlib=true on Windows
and as long as they provide a zlib.lib things should actually work.

(https://reviews.llvm.org/D79219 will remove 2 of the 3 config.h
values, hopefully soon. This change here just makes things a tiny
bit easier until that change is in.)




More information about the All-commits mailing list