[all-commits] [llvm/llvm-project] 9de4ee: [MLIR] Allow unreachable blocks to violate dominan...

[stephenneuendorffer via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9de4ee3815db2b49960e931bcc3c0cc6a28ad0de
      https://github.com/llvm/llvm-project/commit/9de4ee3815db2b49960e931bcc3c0cc6a28ad0de
  Author: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M mlir/include/mlir/IR/Dominance.h
    M mlir/lib/IR/Dominance.cpp
    M mlir/lib/IR/Verifier.cpp
    M mlir/test/IR/invalid.mlir
    M mlir/test/IR/parser.mlir

  Log Message:
  -----------
  [MLIR] Allow unreachable blocks to violate dominance property.

It is possible for optimizations to create SSA code which violates
the dominance property in unreachable blocks.  Equivalently, dominance
computed using normal mechanisms is undefined in unreachable blocks.

See discussion here: https://llvm.discourse.group/t/rfc-allowing-dialects-to-relax-the-ssa-dominance-condition/833/51

This patch only checks the dominance condition inside blocks which are
reachable from the the entry block of their region.  Note that the
dominance conditions of regions contained in an unreachable block are
still checked.

Differential Revision: https://reviews.llvm.org/D79922