[all-commits] [llvm/llvm-project] 85725a: [Flang][OpenMP] Avoid abort when collapse clause v...

Valentin Clement (バレンタイン クレメン) via All-commits all-commits at lists.llvm.org
Thu May 14 18:37:45 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 85725a67c745cb833174a7eae2aa53e74753bcb1
      https://github.com/llvm/llvm-project/commit/85725a67c745cb833174a7eae2aa53e74753bcb1
  Author: Valentin Clement <clementval at gmail.com>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M flang/lib/Semantics/resolve-names.cpp
    M flang/test/Semantics/omp-clause-validity01.f90

  Log Message:
  -----------
  [Flang][OpenMP] Avoid abort when collapse clause value is negative

Summary:
If the value in the collapse close is negative f18 abort without the correct error message. This PR change the size_t in name resolution to a int64_t and check appropriately for negative or zero before the privatization of induction variable.
The correct error is then catch by the OpenMP structure check.

This diff is migrated from the GitHub pull request https://github.com/flang-compiler/f18/pull/1098

Reviewers: ichoyjx, jdoerfert, sscalpone, DavidTruby

Reviewed By: ichoyjx, sscalpone, DavidTruby

Subscribers: sscalpone, klausler, yaxunl, guansong, llvm-commits

Tags: #llvm, #flang

Differential Revision: https://reviews.llvm.org/D77821




More information about the All-commits mailing list