[all-commits] [llvm/llvm-project] eb282b: [RS4GC] Fix algorithm to avoid setting vector BDV ...

annamthomas via All-commits all-commits at lists.llvm.org
Thu May 14 08:18:06 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: eb282be9f8e96053dc7dda687cd0608997810ccf
      https://github.com/llvm/llvm-project/commit/eb282be9f8e96053dc7dda687cd0608997810ccf
  Author: Anna Thomas <anna at azul.com>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
    M llvm/test/Transforms/RewriteStatepointsForGC/scalar-base-vector.ll

  Log Message:
  -----------
  [RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived pointer""

This is relanding of rGbb308b020522420413c7d3f2989a88f2fc423c56 after
speculatively fixing buildbot lit test failure which was seen on two
bots (I cannot reproduce the lit test failure locally either).

[RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived
pointer

Summary:
This is a more general fix to 59029b9eef23 (D75704).
This patch does the following:

updates isKnownBaseValue to account for base pointer and
derived pointer having differing types.

This inturn allows us to populate the
lattice (States) for such derived pointers.

It also updates all states where the base and derived pointers have
differing types (vector versus scalar) and conservatively marks these
states as conflictcs.
Note that in 59029b9eef23, we were just fixing existing lattice values
and that too, only for uses of extractelement.

Reviewers: reames, skatkov, dantrushin

Reviewed By: skatkov

Subscribers: hiraditya, llvm-commits

Differential Revision: https://reviews.llvm.org/D76305




More information about the All-commits mailing list