[all-commits] [llvm/llvm-project] 185895: [libcxx testing] Remove ALLOW_RETRIES from two fut...

[David Zarzycki via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1858953395d2e2d13f6e2e5642b45849c3c388aa
      https://github.com/llvm/llvm-project/commit/1858953395d2e2d13f6e2e5642b45849c3c388aa
  Author: David Zarzycki <dave at znu.io>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M libcxx/test/std/thread/futures/futures.shared_future/wait_until.pass.cpp
    M libcxx/test/std/thread/futures/futures.unique_future/wait_until.pass.cpp

  Log Message:
  -----------
  [libcxx testing] Remove ALLOW_RETRIES from two futures tests

These two tests do not use the "thread sleeps X milliseconds" pattern
that other libcxx tests use, so all we can do in order to remove
ALLOW_RETRIES workaround is remove the assumption that measuring the
"quick" return of `wait()` is possible (it is not). Let the test harness
verify overall that `wait()` does not hang.

As a bonus, have the spin-waiting threads `yield()`, which is what well
behaved code should do.