[all-commits] [llvm/llvm-project] 085234: [cmake] Update creation of object library dependen...

[stephenneuendorffer via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 085234bedc3803699e58a8c9e6bbace3388efee2
      https://github.com/llvm/llvm-project/commit/085234bedc3803699e58a8c9e6bbace3388efee2
  Author: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
  Date:   2020-05-12 (Tue, 12 May 2020)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake

  Log Message:
  -----------
  [cmake] Update creation of object library dependencies for LINK_LIBS PUBLIC

We need to avoid declaring dependencies on strings which are valid
LINK_LIBS and not valid targets.  Previously, we used if(TARGET) to
check this condition.  However, if(TARGET) checks whether a target has
been created (in the cmake subdirectory traversal order) and not
whether it *will* be created.  This results in annoying directory
ordering problems.

This patch changes the check to more explicitly eliminate problematic
libraries (namely -lpthread) using a REGEX.

Differential Revision: https://reviews.llvm.org/D79837