[all-commits] [llvm/llvm-project] 691e82: Revert "[mlir] Revisit std.subview handling of sta...

[Sam McCall via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 691e82699591d8f336cd6be52436eeff2417fab9
      https://github.com/llvm/llvm-project/commit/691e82699591d8f336cd6be52436eeff2417fab9
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2020-05-12 (Tue, 12 May 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
    M mlir/lib/Dialect/StandardOps/IR/Ops.cpp
    M mlir/test/Conversion/StandardToLLVM/convert-to-llvmir.mlir
    M mlir/test/Conversion/StandardToLLVM/invalid.mlir
    M mlir/test/Conversion/StandardToSPIRV/legalization.mlir
    M mlir/test/Conversion/StandardToSPIRV/subview-to-spirv.mlir
    M mlir/test/Dialect/Affine/ops.mlir
    M mlir/test/Dialect/Linalg/promote.mlir
    M mlir/test/IR/core-ops.mlir
    M mlir/test/IR/invalid-ops.mlir
    M mlir/test/Transforms/canonicalize.mlir

  Log Message:
  -----------
  Revert "[mlir] Revisit std.subview handling of static information."

This reverts commit 80d133b24f77d1b9d351251315606441c971ef9b.

Per Stephan Herhut: The canonicalizer pattern that was added creates
forms of the subview op that cannot be lowered.

This is shown by failing Tensorflow XLA tests such as:
  tensorflow/compiler/xla/service/mlir_gpu/tests:abs.hlo.test
Will provide more details offline, they rely on logs from private CI.