[all-commits] [llvm/llvm-project] 2b8b78: Quote error string from qLaunchSuccess

[Jason Molenda via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2b8b783b1ab4a2388d5d80136221729871f65a32
      https://github.com/llvm/llvm-project/commit/2b8b783b1ab4a2388d5d80136221729871f65a32
  Author: Jason Molenda <jason at molenda.com>
  Date:   2020-05-11 (Mon, 11 May 2020)

  Changed paths:
    M lldb/tools/debugserver/source/RNBRemote.cpp

  Log Message:
  -----------
  Quote error string from qLaunchSuccess

If the error message from qLaunchSucess included a gdb RSP
metacharacter, it could crash lldb.  Apply the binary
escaping to the string before sending it to lldb; lldb
promiscuously applies the binary escaping protocol on
packets it receives.

Also fix a small bug in cstring_to_asciihex_string where
a high bit character (eg utf-8 chars) would not be
quoted correctly due to signed char fun.

Differential Revision: https://reviews.llvm.org/D79614

rdar://problem/62873581