[all-commits] [llvm/llvm-project] 2aa021: [FileCheck] Make invalid prefix diagnostics more p...

Joel E. Denny via All-commits all-commits at lists.llvm.org
Mon May 11 18:12:26 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2aa0217add1adbcabbc16e3ec44937e4277e117b
      https://github.com/llvm/llvm-project/commit/2aa0217add1adbcabbc16e3ec44937e4277e117b
  Author: Joel E. Denny <jdenny.ornl at gmail.com>
  Date:   2020-05-11 (Mon, 11 May 2020)

  Changed paths:
    M llvm/lib/Support/FileCheck.cpp
    M llvm/test/FileCheck/validate-check-prefix.txt
    M llvm/utils/FileCheck/FileCheck.cpp

  Log Message:
  -----------
  [FileCheck] Make invalid prefix diagnostics more precise

This will prove especially helpful after D79276, which introduces
comment prefixes.  Specifically, identifying whether there's a
uniqueness violation will be helpful as prefixes will be required to
be unique across both check prefixes and comment prefixes.

Also, remove a related comment about `cl::list` that no longer seems
relevant now that FileCheck is also a library.

Reviewed By: jhenderson, thopre

Differential Revision: https://reviews.llvm.org/D79375




More information about the All-commits mailing list