[all-commits] [llvm/llvm-project] f03b6e: [lld][WebAssembly] Honor --allow-undefined for dat...

Sam Clegg via All-commits all-commits at lists.llvm.org
Wed May 6 12:41:36 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f03b6e785b3469742b9853d855a6e9e81960af0a
      https://github.com/llvm/llvm-project/commit/f03b6e785b3469742b9853d855a6e9e81960af0a
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M lld/test/wasm/undefined-data.ll
    M lld/wasm/Relocations.cpp

  Log Message:
  -----------
  [lld][WebAssembly] Honor --allow-undefined for data symbols too

This was originally the way this worked before before
https://reviews.llvm.org/D60882.

In retrospect it seems inconsistent that `--allow-undefined` doesn't
work for all symbols.  See:
https://groups.google.com/g/emscripten-discuss/c/HSRgQiIq1gI/m/Kt9oFWHiAwAJ

I'm also planning a followup change which implement the full
`--unresolved-symbols=..` flags supported by ELF linkers (both ld and
ld.lld) since it seems more standard.

Differential Revision: https://reviews.llvm.org/D79247




More information about the All-commits mailing list