[all-commits] [llvm/llvm-project] 6adc45: [LLD][COFF] Move debug info for thread-local varia...

[Alexandre Ganea via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6adc45d3fd67cdfc0b653e584ee04232309453fb
      https://github.com/llvm/llvm-project/commit/6adc45d3fd67cdfc0b653e584ee04232309453fb
  Author: Alexandre Ganea <alexandre.ganea at ubisoft.com>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M lld/COFF/PDB.cpp
    M lld/test/COFF/Inputs/pdb-globals.yaml
    M lld/test/COFF/pdb-globals.test

  Log Message:
  -----------
  [LLD][COFF] Move debug info for thread-local variables into PDB global stream

Before this patch, the debug record S_GTHREAD32 which represents global thread_local symbols, was emitted by LLD into the respective module stream. This makes Visual Studio unable to display thread_local symbols in the debugger.

After this patch, S_GTHREAD32 is moved into the globals stream. This matches MSVC behavior.

Differential Revision: https://reviews.llvm.org/D79005


  Commit: f78b674de4531c9092ab1c0c7e4c00196f24e06c
      https://github.com/llvm/llvm-project/commit/f78b674de4531c9092ab1c0c7e4c00196f24e06c
  Author: Alexandre Ganea <alexandre.ganea at ubisoft.com>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
    M llvm/test/DebugInfo/COFF/global-constants.ll
    M llvm/test/DebugInfo/COFF/global_visibility.ll
    M llvm/test/DebugInfo/COFF/globals.ll
    M llvm/test/DebugInfo/COFF/types-array-unsized.ll

  Log Message:
  -----------
  Revert "[Debug][CodeView] Emit fully qualified names for globals"

This reverts commit 06591b6d191ad3582d21a801cbaf56b36714cae7.


Compare: https://github.com/llvm/llvm-project/compare/d5c05ced82ff...f78b674de453